Skip to content

fix(auth): Add missing state transitions for AutoSignIn state #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 16, 2025
Merged

fix(auth): Add missing state transitions for AutoSignIn state #3138

merged 9 commits into from
Oct 16, 2025

Conversation

@mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Oct 9, 2025

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #3135

Description of changes:

  • Adds missing state transitions from autoSignIn state to handle MFA, among other things.
  • Consolidates the state decoding logic across signIn, confirmSignIn, and autoSignIn.

How did you test these changes?

  • Tests pass
  • Manually verified various sign in flows including TOTP setup and TOTP + SMS MFA.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(storage): message, feat(auth): message, chore(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner October 9, 2025 17:14
@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.50000% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.32%. Comparing base (71771e4) to head (3021aad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
+ Coverage   54.26%   54.32%   +0.05%     
==========================================
  Files        1040     1041       +1     
  Lines       32082    31926     -156     
  Branches     4726     4708      -18     
==========================================
- Hits        17410    17344      -66     
+ Misses      12826    12745      -81     
+ Partials     1846     1837       -9
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattcreaser mattcreaser merged commit ef37f18 into main Oct 16, 2025
17 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/autosignin-state-transitions branch October 16, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerjroach tylerjroach tylerjroach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattcreaser @tylerjroach